summaryrefslogtreecommitdiff
path: root/ldso
AgeCommit message (Collapse)Author
2004-01-24Joakim Tjernlund writes:Eric Andersen
Hi again I have done some serious clenup of powerpc/elfinterp.c - Make it look more like glibc. - Performance modifictions. - Fixed a few bugs in _dl_do_reloc(). These seem not to have affected anything, but this how glibc do it. Jocke
2004-01-20As noted by Doru Petrescu, there was a spurious line that was usingEric Andersen
_dl_debug_addr prior to checking if it was NULL.
2004-01-20Paul Mundt writes:Eric Andersen
The current behavior of the powerpc boot1_arch.h seems somewhat broken. Currently room is made on the stack pointer for the link register, but the link register is never actually pushed onto it. glibc bears the following comments: /* Call _dl_start with one parameter pointing at argc */ mr r3,r1 /* (we have to frob the stack pointer a bit to allow room for _dl_start to save the link register). */ followed by the -16 add to r1. Despite the fact that r1 is modified, the link register is never actually pushed onto r1, thus the adjustment is completely superfluous. There's two possible fixes for this, either saving the link register in the way that glibc does, or getting rid of the r1 adjustment. As I'm not sure if saving the link register will actually break the _dl_boot2 callin, both options will probably want to be played with. The following bit of inline assembly in the attached patch builds cleanly for me with gcc 3.3 on darwin, but I'm not able to test it any further beyond that.
2004-01-20Joakim Tjernlund writes:Eric Andersen
> Is there anything I can do/provide that would assist in the solving of > this problem on PowerPC? I'm still concerned about my lack of flash space... Try this path. It fixes the recent ldso problems for me on my mpc860 board. You should be able to use ldso without the dcbx patch to the kernel now. Please report back. Jocke
2004-01-16We need to link with libgcc.a when creating shared libs, in order toManuel Novoa III
avoid problems 'hidden symbol' problems. Also handle -lfloat for the soft-float arm case.
2004-01-16Make sure we remove -fomit-frame-pointer from the ldso build. It'sDavid McCullough
inclusion will cause the loader to crash when jumping to the application. The reason is due to the START macro having a "leave" instruction included to fixup the stack before starting the app.
2004-01-06Some badly behaved arches fail to provide a PAGE_SIZE defineEric Andersen
2004-01-02Peter S. Mazinger writes:Eric Andersen
Hello Erik! I have made some cosmetical changes to the files, removed the added SCRT=-fPIC option from building the crt0.S file (but it is a requirement to build them with -fPIC), and changed some comments. I have left the ldso.c patch with PIE_SUPPORT ifdefs, but consider applying it w/o them (see some earlier comment from PaX Team on this issue, as it is considered a bug). To have it work correctly, you'll also need removing COMPLETELY_PIC. One thing is missing: PIE_SUPPORT should be usable only for i386 (for now). Also added the support for propolice protection (that works for me and catches memcpy/strcpy attacks (but needs a special gcc version). Thanks, Peter
2003-12-17Use PAGE_SIZE rather than hard coding 4096Eric Andersen
2003-12-17Patch from Paul Mundt <lethal@linux-sh.org>:Eric Andersen
Here's the patch for the ldso bits for sh64. This is still in need of a bunch of debugging, testing, etc. and is really only being submitted for general completeness. This assumes that the previous patches I've submitted have already been applied. I plan on playing with this and buildroot some more later, as I'd definitely like to see buildroot images for sh64.
2003-12-17Patch from Paul Mundt <lethal@linux-sh.org>:Eric Andersen
For sh64 we need implicit access to the symtab, primarily to get at the ->st_other value. This presently isn't possible, as PERFORM_BOOTSTRAP_RELOC() is invoked as such: PERFORM_BOOTSTRAP_RELOC(rpnt, reloc_addr, symbol_addr, load_addr); while we can easily get the symtab_index value from rpnt->r_info, this still doesn't buy us easy access to the actual table. As such, I've modified PERFORM_BOOTSTRAP_RELOC() to take an additional SYMTAB argument. Most architectures aren't going to care about this, but unfortunately we don't have any other options for sh64. The following patch fixes up the API for what we need for sh64, and updates the other architectures appropriately.
2003-12-17When I switched from using stack allocated space for printf, I missed a caseEric Andersen
where a sizeof(foo) was changed to the sizeof a pointer. This caused _dl_printf to complain a lot when debug is enabled (which itself revealed a bug since it should have exited on buffer overflow), and let me to find another bug, where memory failures would try to recursively call _dl_printf.... What a mess.
2003-12-05move _dl_fixup so staticly linked apps using dlopen have aEric Andersen
chance of actually working
2003-12-03Henrik Grindal Bakken writes:Eric Andersen
The patch touches a minor (well, not that minor, but perhaps only rarely encountered) bug in the powerpc dynamic linker. The problem is that addi is called in inline assembly, but there is no restriction on the second argument. In powerpc assembler, if the second argument to addi is r0, it is taken as the value 0, not the contents of r0. This happened to me, making the stack pointer 0 on the invocation on the application. The patch is against 0.9.22, but there didn't seem to be any changes to the relevant section in 0.9.23.
2003-12-03Joakim Tjernlund writes:Eric Andersen
This is just a wild guess, but you could try this to see if it fixes Richards problem:
2003-12-03Eliminate some static buffers based on a patch from Tobias AnderbergEric Andersen
2003-11-22Only enable debugging when SUPPORT_LD_DEBUG is enabled, not DEBUGGINGEric Andersen
2003-11-22Oops. Only enable debug when debugging...Eric Andersen
2003-11-13Joakim Tjernlund writes:Eric Andersen
I think I messed up a little in my latest patch to Erik. Can you try this on top of CVS(which I think you have already) Jocke And later writes: Hi Erik I just saw something that might be a problem. The "delta" variable is signed and the "delta" calculations, such as delta = PLT_LONGBRANCH_ENTRY_WORDS*4 - (insn_addr-plt_addr+4), are supposed to be unsigned. Jocke
2003-11-11It seems that the powerpc ldso doesn't like -O0Eric Andersen
2003-11-11Joakim Tjernlund writes:Eric Andersen
Comparing glibc with uClibc makes me think that the delta calculations are wrong here. Comparing some more I still think there are a data_words[index] assignments missing. Here is a path that has both the data_words[index] and the above delta calclations. This also fixes a terribly obvious bug, also spotted by Joakim, which Erik introduced when he copied things from the i386 ldso code. With this patch applied, things now seem to be working perfectly!
2003-11-11Another cleanup patch from Joakim Tjernlund:Eric Andersen
Hi again Back at work. Here is a patch that fixes the 2 errors I found yesterday. I have excluded the "data_words[index]" part for now.
2003-11-08Sigh. I can't type this morning.Eric Andersen
2003-11-08Joakim Tjernlund writes:Eric Andersen
Oops, found another ppc 8xx bug. 8xx CPUs may need this as well to work:
2003-11-08Joakim Tjernlund writes:Eric Andersen
> Very interesting. Do you have any suggestions for how > we could fix our powerpc shared library loader Removing those instr. comes with a very big performance penalty. To flush the dcache you will have read up to 8KB dummy data and to invalidate the icache you will have to execute up to 16KB nops. I don't know of any other way from user space. hmm, actually I think it will work reliable to perform a store to the same page(s) as the dcbst/icbi will act on. That way you will make the DTLB Error happen(if any) prior to the dcbst/icbi. The worst thing that can happen then is a regular DTLB Miss and that works for dcbst/icbi. You will have to lookout for if dcbst/icbi crosses a page boundary. Then you will have to perform a store to both pages. Jocke # And again later writes: Hi again I think I know what the problem is. The PPC_DCBST;PPC_SYNC;PPC_ICBI;PPC_ISYNC sequence is executed even if no modification has been done i some cases: _dl_linux_resolver(), the last else has no store for insns[0]. these is a insns[1] = OPCODE_B(delta - 4) that does not have a PPC_DCBST. _dl_do_lazy_reloc(), for R_PPC_NONE there is no store. for R_PPC_JMP_SLOT there is a insns[1] = OPCODE_B(delta)that does not have a PPC_DCBST. _dl_do_reloc(), for R_PPC_COPY there is no store. for R_PPC_JMP_SLOT there is a reloc_addr[1] = OPCODE_B(delta) that does not have a PPC_DCBST. _dl_init_got(), I THINK that the PPC_DCBST(plt); PPC_DCBST(plt+4); PPC_DCBST(plt+8); PPC_SYNC; PPC_ICBI(plt); PPC_ICBI(plt+4); PPC_ICBI(plt+8); PPC_ISYNC; is off a bit. The address range does not match the sum of the plt[] and tramp[] address range. Jocke # And then later added the comment: I think that the tramp[] part should be included in the PPC_DCBST/PPC_ICBI sequence. Then you have to add entries for plt+12 and plt+16. If the tramp[] part should be excluded, then all is well. Jocke
2003-11-06Begin converting the client utilsEric Andersen
2003-11-06Revert change 1.26, which breaks everything. :-(Eric Andersen
2003-11-06A few debugging cleanupsEric Andersen
2003-11-05Fix a misnamed arrayEric Andersen
2003-11-05tiny cleanupEric Andersen
2003-11-05Rework the powerpc lib loader to better match the other architecturesEric Andersen
2003-11-05Fix a buglet that shows up on powerpcEric Andersen
2003-11-04Rework the config system. Better utilize the Kconfig languageEric Andersen
which should simplify enabling arbitrary architectures. -Erik
2003-10-31Some more soft float fixes... for arm in particular (libfloat).Manuel Novoa III
Remove the ADD_LIBGCC_FUNCTIONS option and do things the right way. Either we have a shared libgcc available, or the libgcc routines aren't PIC and don't belong in the shared libc anyway.
2003-10-18Peter Kjellerstedt writes:Eric Andersen
ln.patch: * Define $(LN) as ln in Rules.mak. * Change all occurrences of ln into $(LN). * Change all constructs like (cd path && ln -sf foo/file file) into $(LN) -sf foo/file path/file. The latter construct is already used in a number of places so it should not be an additional compatibility problem.
2003-10-18Peter Kjellerstedt writes:Eric Andersen
rm.patch: * Define $(RM) as rm -f in Rules.mak and test/Rules.mak (this is the same definition as gmake uses by default). * Change all occurrences of rm and rm -f into $(RM).
2003-10-18Peter Kjellerstedt writes:Eric Andersen
install.patch: * Define $(INSTALL) as install in Rules.mak. * Change all occurrences of install into $(INSTALL). * Change all occurrences of mkdir -p into $(INSTALL) -d. install -d is already used in a number of places so this should not be an additional compatibility problem.
2003-10-15Doh! I was returning with an incorrect pointer type when dlopeningEric Andersen
already loaded libs, which unsurprisingly would cause dlsym() to not work at all... -Erik
2003-10-14Enable full debug support for ld-uClibc and libdlEric Andersen
2003-10-13sigh. the warn funcs seem to be broken. Use local versionsEric Andersen
till I can straighten that out.
2003-10-13Fix an ldd bug, more ldconfig cleanupEric Andersen
2003-10-12Always build and install ldconfigEric Andersen
2003-10-09move the test for loading the wrong C library into theEric Andersen
_dl_check_if_named_library_is_loaded function
2003-10-09When someone would dlopen a shared lib that was already opened,Eric Andersen
we would try to re-fixup the lib's relocations with rather horrible results. So fix that by checking the the dlopened lib has already had its init functions called, which will never be the case for newly loaded libs, and skip the rest in that case. also apply a few minor fixups
2003-10-04Fix a stupid bug causing 'ldd' output to not contain the fullEric Andersen
path to the target library
2003-09-30Don't forget addend on relocations + minor other fixes.Tobias Anderberg
2003-09-29Fix SUPPORT_LD_DEBUG_EARLY on powerpcEric Andersen
2003-09-19* Partial re-write to match other archs and remove duplicate code.Tobias Anderberg
* Assign insead of add when doing relocations.
2003-09-19Corrected LD_BOOT macroTobias Anderberg
2003-09-19Initialize strings as pointers instead of arrays.Tobias Anderberg