summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--libc/misc/time/time.c1
-rw-r--r--test/time/tst-ctime.c44
2 files changed, 45 insertions, 0 deletions
diff --git a/libc/misc/time/time.c b/libc/misc/time/time.c
index 758a737fd..ff44892a8 100644
--- a/libc/misc/time/time.c
+++ b/libc/misc/time/time.c
@@ -479,6 +479,7 @@ char *ctime(const time_t *t)
* localtime's static buffer:
*/
struct tm xtm;
+ memset(&xtm, 0, sizeof(xtm));
return asctime(localtime_r(t, &xtm));
}
diff --git a/test/time/tst-ctime.c b/test/time/tst-ctime.c
new file mode 100644
index 000000000..91d827aa2
--- /dev/null
+++ b/test/time/tst-ctime.c
@@ -0,0 +1,44 @@
+/* vi: set sw=4 ts=4: */
+/* testcase for ctime(3) with large time
+ * Copyright (C) 2010 David A Ramos <daramos@gustav.stanford.edu>
+ * Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <time.h>
+
+#define MAX_POSITIVE(type) (~0 & ~((type) 1 << (sizeof(type)*8 - 1)))
+
+int do_test(int argc, char **argv) {
+ char *correct = 0, *s;
+ int status;
+
+ /* need a very high positive number (e.g., max - 1024) */
+ time_t test = MAX_POSITIVE(time_t) - 1024;
+
+ s = asctime(localtime(&test));
+
+ if (s) {
+ // copy static buffer to heap
+ correct = malloc(strlen(s)+1);
+ strcpy(correct, s);
+ }
+
+ s = ctime(&test);
+
+ printf("ANSI:\t%suClibc:\t%s", correct, s);
+
+ if (s != correct && strcmp(correct, s))
+ status = EXIT_FAILURE;
+ else
+ status = EXIT_SUCCESS;
+
+ if (correct)
+ free(correct);
+
+ return status;
+}
+
+#include <test-skeleton.c>