From 85800279bcad0b3495ccc22374f42cd04675f9e4 Mon Sep 17 00:00:00 2001 From: Eric Andersen Date: Fri, 24 Jan 2003 11:44:14 +0000 Subject: Ok, people are probably going to hate me for this... This commit changes the type of 'struct stat' and 'struct stat64' so they use consistant types. This change is the result of a bug I found while trying to use GNU tar. The problem was caused by our using kernel types within struct stat and trying to directly compare these values with standard types. Trying an 'if (a < b)' when 'a' is an 'unsigned long' and 'b' is an 'int' leads to very different results then when comparing entities of the same type (i.e. time_t values).... Grumble. Nasty stuff, but I'm glad I got this out of the way now. As a result of this fix, uClibc 0.9.17 will not be binary compatible with earlier releases. I have always warned people this can and will happen. -Erik --- libc/sysdeps/linux/cris/bits/kernel_stat.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'libc/sysdeps/linux/cris/bits') diff --git a/libc/sysdeps/linux/cris/bits/kernel_stat.h b/libc/sysdeps/linux/cris/bits/kernel_stat.h index 5f0c0f4fe..38f5036a2 100644 --- a/libc/sysdeps/linux/cris/bits/kernel_stat.h +++ b/libc/sysdeps/linux/cris/bits/kernel_stat.h @@ -17,7 +17,7 @@ struct __old_kernel_stat { unsigned long st_ctime; }; -struct stat { +struct kernel_stat { unsigned short st_dev; unsigned short __pad1; unsigned long st_ino; @@ -40,10 +40,10 @@ struct stat { unsigned long __unused5; }; -/* This matches struct stat64 in glibc2.1, hence the absolutely +/* This matches struct kernel_stat64 in glibc2.1, hence the absolutely * insane amounts of padding around dev_t's. */ -struct stat64 { +struct kernel_stat64 { unsigned short st_dev; unsigned char __pad0[10]; -- cgit v1.2.3