From 07bbf922670cce83c0b54f28ad43473d044cae5e Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Sat, 12 Apr 2008 01:34:04 +0000 Subject: Functions should be either exported in public .h files and marked with libc_hidden_proto/def(), or not be exported in .h files and be hidden (or even static if possible). We have five functions which violate this. Fixing: netdb.h: export ruserpass() rpc/rpc.h: export xdr_accepted_reply() and xdr_rejected_reply() make inet_ntoa_r static function (it is not exported in any .h file) make _time_tzset hidden function (it is not exported in any .h file) --- libc/inet/addr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'libc/inet/addr.c') diff --git a/libc/inet/addr.c b/libc/inet/addr.c index 94fa3aab7..cbe3d6893 100644 --- a/libc/inet/addr.c +++ b/libc/inet/addr.c @@ -122,9 +122,7 @@ libc_hidden_def(inet_addr) #define INET_NTOA_MAX_LEN 16 /* max 12 digits + 3 '.'s + 1 nul */ -extern char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]); -libc_hidden_proto(inet_ntoa_r) -char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]) +static char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]) { in_addr_t addr = ntohl(in.s_addr); int i; @@ -143,7 +141,6 @@ char *inet_ntoa_r(struct in_addr in, char buf[INET_NTOA_MAX_LEN]) return p+1; } -libc_hidden_def(inet_ntoa_r) libc_hidden_proto(inet_ntoa) char *inet_ntoa(struct in_addr in) -- cgit v1.2.3